stream: rename Duplex.toWeb() type option to readableType#61632
Open
Renegade334 wants to merge 1 commit intonodejs:mainfrom
Open
stream: rename Duplex.toWeb() type option to readableType#61632Renegade334 wants to merge 1 commit intonodejs:mainfrom
Duplex.toWeb() type option to readableType#61632Renegade334 wants to merge 1 commit intonodejs:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #61632 +/- ##
==========================================
+ Coverage 89.73% 89.75% +0.01%
==========================================
Files 673 673
Lines 203948 203954 +6
Branches 39193 39194 +1
==========================================
+ Hits 183022 183051 +29
+ Misses 13240 13239 -1
+ Partials 7686 7664 -22
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The webstreams standard uses the name
readableTypefor a source property which specifies thetypeof the readable component of a constructed readable-writable pair.1 Although this is only future-proofed nomenclature at the moment, we should probably follow this convention here, for consistency and just in case we also need to support WritableStream types in the future.This paradigm would also be consistent with
Duplex.toWeb()takingreadableStrategyandwritableStrategyoptions in the future, if so desired.Because
Duplex.toWeb()is no longer marked as experimental, I believe that removingoptions.typeentirely would need a full deprecation cycle, so I've just turned it into a silent alias for simplicity.Refs: #58664
Footnotes
https://streams.spec.whatwg.org/#dictdef-transformer ↩